Empty Code Block
An empty code block occurs when a section of source code, such as a conditional statement or function body, contains no executable statements.
Empty blocks can appear in various places like if/else conditionals, loops, function definitions, or exception handlers. While sometimes intentionally used as a placeholder, they often signal problems like incomplete features, accidentally deleted logic, or unexpected behavior from macros or code generators. For developers, these empty blocks are a red flag. Even if the language syntax allows them, they frequently violate API contracts or expected program behavior, leading to silent failures or security issues where an action is assumed but never executed. Code reviews should actively identify and justify any empty block to prevent unintentional gaps in application logic.
Impact: Reduce Reliability
ID : DX-213
In the following Java example, the code catches an ArithmeticException.Code Example:
javaCode Example:
javaID : DX-214
The following code attempts to synchronize on an object, but does not execute anything in the synchronized block. This does not actually accomplish anything and may be a sign that a programmer is wrestling with synchronization but has not yet achieved the result they intend.Code Example:
javaCode Example:
java