Double-Checked Locking

Draft Base
Structure: Simple
Description

Double-checked locking is an insufficient synchronization pattern where a program checks a resource's state, acquires a lock, and checks the state again before initialization, failing to guarantee thread safety across all systems.

Extended Description

Double-checked locking attempts to optimize performance by avoiding the cost of synchronization on every access. A thread first checks if a resource (like an object) is initialized without a lock. If it appears uninitialized, the thread then acquires a lock, performs a second check, and only initializes the resource if the second check also confirms it's needed. This pattern aims to minimize lock contention but is fundamentally flawed. The core issue is that this sequence is not guaranteed to be atomic or visible in the same order to other threads running concurrently. Without proper synchronization on the initial check, other threads might see a partially constructed object or cache the uninitialized state, leading to unpredictable behavior and crashes. Because memory model guarantees vary across programming languages and hardware architectures, this pattern is unreliable and should be replaced with thread-safe initialization methods.

Common Consequences 1
Scope: IntegrityOther

Impact: Modify Application DataAlter Execution Logic

Potential Mitigations 1
Phase: Implementation
While double-checked locking can be achieved in some languages, it is inherently flawed in Java before 1.5, and cannot be achieved without compromising platform independence. Before Java 1.5, only use of the synchronized keyword is known to work. Beginning in Java 1.5, use of the "volatile" keyword allows double-checked locking to work successfully, although there is some debate as to whether it achieves sufficient performance gains. See references.
Demonstrative Examples 1

ID : DX-70

It may seem that the following bit of code achieves thread safety while avoiding unnecessary synchronization...

Code Example:

Bad
Java
java
The programmer wants to guarantee that only one Helper() object is ever allocated, but does not want to pay the cost of synchronization every time this code is called.
Suppose that helper is not initialized. Then, thread A sees that helper==null and enters the synchronized block and begins to execute:

Code Example:

Bad
Java
java
If a second thread, thread B, takes over in the middle of this call and helper has not finished running the constructor, then thread B may make calls on helper while its fields hold incorrect values.
References 3
The "Double-Checked Locking is Broken" Declaration
David Bacon et al
ID: REF-490
JSR 133 (Java Memory Model) FAQ
Jeremy Manson and Brian Goetz
ID: REF-491
The Art of Software Security Assessment
Mark Dowd, John McDonald, and Justin Schuh
Addison Wesley
2006
ID: REF-62
Applicable Platforms
Languages:
Java : Undetermined
Modes of Introduction
Implementation
Taxonomy Mapping
  • The CERT Oracle Secure Coding Standard for Java (2011)
  • Software Fault Patterns