Automated static analysis, commonly referred to as Static Application Security Testing (SAST), can find some instances of this weakness by analyzing source code (or binary/compiled code) without having to execute it. Typically, this is done by building a model of data flow and control flow, then searching for potentially-vulnerable patterns that connect "sources" (origins of input) with "sinks" (destinations where the data interacts with external components, a lower layer such as the OS, etc.)
Incorrect Regular Expression
This vulnerability occurs when a regular expression is written incorrectly, causing it to match or validate data in unintended and potentially dangerous ways.
What is CWE-185?
Real-world CVEs caused by CWE-185
-
Regexp isn't "anchored" to the beginning or end, which allows spoofed values that have trusted values as substrings.
-
Regexp for IP address isn't anchored at the end, allowing appending of shell metacharacters.
-
Bypass access restrictions via multiple leading slash, which causes a regular expression to fail.
-
Local user DoS via invalid regular expressions.
-
chain: Malformed input generates a regular expression error that leads to information exposure.
-
Certain strings are later used in a regexp, leading to a resultant crash.
-
MFV. Regular expression intended to protect against directory traversal reduces ".../...//" to "../".
-
Malformed regexp syntax leads to information exposure in error message.
Trajeto do atacante passo a passo
- 1
The following code takes phone numbers as input, and uses a regular expression to reject invalid phone numbers.
- 2
An attacker could provide an argument such as: "; ls -l ; echo 123-456" This would pass the check, since "123-456" is sufficient to match the "\d+-\d+" portion of the regular expression.
- 3
This code uses a regular expression to validate an IP string prior to using it in a call to the "ping" command.
- 4
Since the regular expression does not have anchors (CWE-777), i.e. is unbounded without ^ or $ characters, then prepending a 0 or 0x to the beginning of the IP address will still result in a matched regex pattern. Since the ping command supports octal and hex prepended IP addresses, it will use the unexpectedly valid IP address (CWE-1389). For example, "0x63.63.63.63" would be considered equivalent to "99.63.63.63". As a result, the attacker could potentially ping systems that the attacker cannot reach directly.
Vulnerable Perl
The following code takes phone numbers as input, and uses a regular expression to reject invalid phone numbers.
$phone = GetPhoneNumber();
if ($phone =~ /\d+-\d+/) {
```
# looks like it only has hyphens and digits*
system("lookup-phone $phone");}
else {
```
error("malformed number!");
} Secure pseudo
// Validate, sanitize, or use a safe API before reaching the sink.
function handleRequest(input) {
const safe = validateAndEscape(input);
return executeWithGuards(safe);
} How to prevent CWE-185
- Architecture and Design Regular expressions can become error prone when defining a complex language even for those experienced in writing grammars. Determine if several smaller regular expressions simplify one large regular expression. Also, subject the regular expression to thorough testing techniques such as equivalence partitioning, boundary value analysis, and robustness. After testing and a reasonable confidence level is achieved, a regular expression may not be foolproof. If an exploit is allowed to slip through, then record the exploit and refactor the regular expression.
How to detect CWE-185
O Plexicus deteta automaticamente o CWE-185 e abre um PR de correção em menos de 60 segundos.
O Codex Remedium analisa cada commit, identifica esta fraqueza exata e entrega um pull request pronto para revisão com o patch. Sem tickets. Sem transferências.
Frequently asked questions
O que é o CWE-185?
This vulnerability occurs when a regular expression is written incorrectly, causing it to match or validate data in unintended and potentially dangerous ways.
Qual a gravidade do CWE-185?
A MITRE não publicou uma classificação de probabilidade de exploração para esta fraqueza. Trate-a como impacto médio até o seu modelo de ameaças provar o contrário.
Que linguagens ou plataformas são afetadas pelo CWE-185?
A MITRE não especificou as plataformas afetadas por este CWE — pode aplicar-se à maioria das stacks de aplicações.
Como posso prevenir o CWE-185?
Regular expressions can become error prone when defining a complex language even for those experienced in writing grammars. Determine if several smaller regular expressions simplify one large regular expression. Also, subject the regular expression to thorough testing techniques such as equivalence partitioning, boundary value analysis, and robustness. After testing and a reasonable confidence level is achieved, a regular expression may not be foolproof. If an exploit is allowed to slip…
Como é que o Plexicus deteta e corrige o CWE-185?
O motor SAST do Plexicus correlaciona a assinatura de fluxo de dados do CWE-185 em cada commit. Quando é encontrada uma correspondência, o nosso agente Codex Remedium abre um PR de correção com o código corrigido, testes e um resumo de uma linha para o revisor.
Onde posso saber mais sobre o CWE-185?
A MITRE publica a definição canónica em https://cwe.mitre.org/data/definitions/185.html. Pode também consultar a documentação da OWASP e do NIST para orientações adjacentes.
Weaknesses related to CWE-185
Incorrect Comparison
This weakness occurs when a security-critical decision relies on a flawed comparison between two pieces of data. The incorrect logic can…
Incomplete Comparison with Missing Factors
This weakness occurs when a program compares two items but fails to check all the necessary attributes that define their true…
Comparison of Incompatible Types
This vulnerability occurs when code directly compares two values of fundamentally different data types, which can lead to unreliable or…
Comparison Using Wrong Factors
This weakness occurs when a program compares two items but checks the wrong properties or attributes. This flawed comparison leads to…
Inadequate Detection or Handling of Adversarial Input Perturbations in Automated Recognition Mechanism
This vulnerability occurs when a system uses automated AI or machine learning to classify complex inputs like images, audio, or text, but…
Floating Point Comparison with Incorrect Operator
This vulnerability occurs when code compares two floating-point numbers using direct equality operators (like == or !=) without accounting…
Incorrect Comparison Logic Granularity
This vulnerability occurs when a system compares sensitive data, like passwords or authentication tokens, piece-by-piece instead of as a…
Permissive List of Allowed Inputs
This vulnerability occurs when an application's security filter uses an allowlist that is too broad, mistakenly permitting dangerous…
Object Model Violation: Just One of Equals and Hashcode Defined
This vulnerability occurs when a Java class defines either the equals() method or the hashCode() method, but not both, breaking a…
Pare de pagar por desenvolvedor.
Comece a fechar o ciclo.
O Plexicus é o ASPM nativo de IA que verifica, filtra, corrige, pentesta e explica — de forma autónoma. Programadores ilimitados, repos ilimitados, ações de IA de utilização justa. Nível gratuito real, €269/mo anual quando estiver pronto.